Cleaning up the mess

[vaulted947]

Does the keyword static sound familiar anyhow?
What's the deal with a zillion of globals floating around? And most of them have very distinctive names, like 'a' or 'x'...
No wonder that there are all kind of crashes under gcc, and linking problems under VS.

I'm currently cleaning up all that mess (removing unneeded globals and marking variables static where appropriate) and I would like to merge that back to SVN. Could I ask someone with full SVN access to help me with that?

Speaking about the Enhanced version, why using STL and streams? Wouldn't it be better to stick with basic C++ features to ease the portability? Cause, for example, I'm currently trying to port that to PS2 and there is no STL support in PS2SDK, so I'm stuck with the bugridden Classic version.

[Mindless]

Classic is bug-ridden?

gcc crashes? VS linking problems? This is the first time I've heard of such problems.

I'll admit the code is messy, and Jason wouldn't deny it either -- he wasn't writing it for public consumption.

Feel free to submit patches and bug the devs until they do something with it.

[yuriks]

OpenTyrian is that way because that's the way the original Tyrian was.
I can't say I like that, we're getting rid of it right now. And I'm using the C++ std. lib because it's just that, standard, makes coding easier and is faster, usually. It's not my fault your shitty compiler doesn't support it properly.

[vaulted947]

Sorry if that sounded rude, but I'm quite pissed off about the same old opensource story - nothing is working, got to spend hours to get something out of it.
And that compiler is indeed shitty but it isn't mine and unfortunately that's the only available compiler for PS2.

How would it be possible to apply for the SVN access?

[yuriks]

Read only SVN access can be had at opentyrian.googlecode.com/svn/
To commit stuff send us a patch and we'll review and maybe apply it. Patches which have removing the use of templates and the standard lib as features won't be accepted. (At least by me) =P

Removing globals/etc is something that is slowly being worked on anyway, so I'll gladly accept that kind of stuff as long as it doesn't breaks anything (and sometimes it's hard to tell, the code is quite quirky and depentand on datatype sizes and stuff like that in places).

[evilmaus]

Is there anything that a C++ novice could do to help?